#42 - add StylableInputBox #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add StylableInputBox (currently supports Text and Number) - add StylableInputBoxBuilder
# Conflicts: # README.md # StylableWinFormsControls/StylableWinFormsControls.Example/FrmDefault.Designer.cs # StylableWinFormsControls/StylableWinFormsControls.Example/FrmDefault.cs
|
@wolframhaussig: Please review my proposed changes. As we talked about, I've combined as much duplicate code into one where I could. |
- make base class abstract - removed duplicate code in Builders - provide typesafe access to the input value - removed usage of typed parameters for the user - reuse InputControl for Checkbox from MessageBox
Nockiro
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Checklist
(Please strikethrough all not applicable points instead of removing them)