feat(plugin/page_vote): add page_vote plugin
#983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjust code structure disable `page vote` plugin by default
Liumingxun
commented
Sep 22, 2024
qwqcode
force-pushed
the
master
branch
5 times, most recently
from
6706fce to
db960aa
Compare
qwqcode
added a commit
that referenced
this pull request
Oct 6, 2024
A new HTTP API endpoint `GET /votes/:target_name/:target_id` is now available.
Response example:
```
{"up":1,"down":1,"is_up":true,"is_down":false}
```
- Implement GET endpoint for retrieving vote status
- Add tests for vote functionality
Related to: PR#997
This is a prerequisite PR for #983.
qwqcode
added a commit
that referenced
this pull request
Oct 6, 2024
A new HTTP API endpoint `GET /votes/:target_name/:target_id` is now available. (See https://artalk.js.org/http-api.html#tag/Vote/operation/GetVote) - Implement GET endpoint for retrieving vote status - Add tests for vote functionality Related to: #997 This is a prerequisite PR for #983.
|
Thank you for your PR. You provided me with a design idea for this feature. I took some time to think and made some modifications based on your code, including:
I have performed some basic manual testing on the frontend. If you have any additional insights or suggestions, I’d love to hear them! Feel free to discuss! 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the "vote up/down page" button should be appended to a specified element. Style and update vote count still have some problem, but it's a work in progress.
Feel free to discuss with me and share your thoughts.
close #944