Added instructions to use Gazebo sources with rosdep
#6656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanf55
suggested changes
Mar 2, 2025
| sudo apt update | ||
| rosdep update | ||
| rosdep install --from-paths src --ignore-src -r | ||
| rosdep install --from-paths src --ignore-src -y |
There was a problem hiding this comment.
You should leave in sudo apt update and rosdep update. It's necessary. Please only remove the -r flag.
dev/source/docs/ros2-gazebo.rst
Outdated
| echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/pkgs-osrf-archive-keyring.gpg] http://packages.osrfoundation.org/gazebo/ubuntu-stable $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/gazebo-stable.list > /dev/null | ||
| sudo apt update | ||
|
|
||
| Add Gazebo sources to `rosdep`. |
There was a problem hiding this comment.
Suggested change
| Add Gazebo sources to `rosdep`. | |
| Add Gazebo sources to `rosdep` for the non-default paring of ROS 2 humble and Gazebo Harmonic. |
It's helpful to explain context.
|
@Ryanf55 Thanks for the feedback. I have made the requested changes! |
Ryanf55
approved these changes
Mar 4, 2025
dev/source/docs/ros2-gazebo.rst
Outdated
| @@ -44,7 +44,7 @@ Add Gazebo APT sources. | |||
| echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/pkgs-osrf-archive-keyring.gpg] http://packages.osrfoundation.org/gazebo/ubuntu-stable $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/gazebo-stable.list > /dev/null | |||
| sudo apt update | |||
|
|
|||
| Add Gazebo sources to `rosdep`. | |||
| Add Gazebo sources to `rosdep` for the non-default paring of ROS 2 humble and Gazebo Harmonic. | |||
There was a problem hiding this comment.
Suggested change
| Add Gazebo sources to `rosdep` for the non-default paring of ROS 2 humble and Gazebo Harmonic. | |
| Add Gazebo sources to `rosdep` for the non-default pairing of ROS 2 humble and Gazebo Harmonic. |
Just a spelling error, otherwise LGTM.
There was a problem hiding this comment.
Sorry about that. Fixed the mistake!
|
squash commits and I'll merge it..thanks |
Signed-off-by: Saurabh Kamat <[email protected]>
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the discussion in ArduPilot/ardupilot_ros#32, this update improves the "ROS 2 with Gazebo" setup instructions by adding Gazebo sources to
rosdep.The current approach allows users to bypass
rosdeperrors using the-rflag, which can later lead to build failures. By instructing users to add Gazebo sources, rosdep will properly install the requiredgzlibraries.