-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for SITL build #4942
base: master
Are you sure you want to change the base?
Fix for SITL build #4942
Conversation
./waf configure --board=sitl --toolchain i686-pc-cygwin was causing a crash because it couldn't find i686-pc-cygwin. Adding these links allows the build script to complete as written.
To add to that, at some cygwin will be deprecated from ArduPilot in favor of WSL. |
@rmackay9 are you still using cygwin that you can test this? |
Actually, @meee1 would be interested in this because I think Mission Planner relies cygwin a little bit for SITL |
different thing....MP takes a github action build from CI....this is a developer thing |
Setting x64 as i686 is not a good things IMHO. |
This whole section "Build SITL binaries for Windows" can be deleted, I think. This section is for building 32-bit cygwin binaries, which nobody can do now (as the author notes, this is being deprecated). As I understand it, this documentation PR has the user create symlinks so that the 64-bit compiler runs when you ask waf to build with the 32-bit toolchain. That's not necessary. Just run with the default build options in cygwin and it will create the 64-bit binaries that Mission Planner now uses (at least, MP beta). Source: I am one of the wierdos that does this. |
That is interesting! I think it'd still be useful to keep some mention of using cygwin for Mission Planner's exe SITL builds though. |
./waf configure --board=sitl --toolchain i686-pc-cygwin was causing a crash because it couldn't find i686-pc-cygwin. Adding these links allows the build script to complete as written.