Changed memberproc to FUNCTOR in Learning the code-Threading page #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterbarker review please |
peterbarker
requested changes
Jun 14, 2023
There was a problem hiding this comment.
Whoops - I guess this shows just how badly out-of-date documentation can get, and how much it can hurt when it does. Sorry to hear about your lost time :-/
I figure we just swipe a line of code from the current codebase that (presumably) works, which is my suggestion here.
| @@ -42,10 +42,10 @@ hal.scheduler->register_timer_process() like this: | |||
|
|
|||
| :: | |||
|
|
|||
| hal.scheduler->register_timer_process(AP_HAL_MEMBERPROC(&AP_Baro_MS5611::_update)); | |||
| hal.scheduler->register_timer_process(FUNCTOR(&AP_Baro_MS5611::_update)); | |||
There was a problem hiding this comment.
Suggested change
| hal.scheduler->register_timer_process(FUNCTOR(&AP_Baro_MS5611::_update)); | |
| hal.scheduler->register_timer_process(FUNCTOR_BIND_MEMBER(&AP_Camera_Backend::feedback_pin_timer, void)) |
|
|
||
| that particular example is from the MS5611 barometer driver. The | ||
| AP_HAL_MEMBERPROC() macro provides a way to encapsulate a C++ member | ||
| FUNCTOR() macro provides a way to encapsulate a C++ member |
There was a problem hiding this comment.
Suggested change
| FUNCTOR() macro provides a way to encapsulate a C++ member | |
| FUNCTOR_BIND() macro provides a way to encapsulate a C++ member |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example for registering a timer callback used a deprecated function called memberproc(). I spent multiple days trying to successfully register a callback before I realized that FUNCTOR is the new and updated way to wrap functions. This update will help streamline newcomers into development.
This addresses issue 1339
#1339