common: Use ifconfig directive in place of [site wiki=...] #4438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one might be interesting from a build perspective. In the conf.py files there is an extension for the ifconfig directive that has been there for 6 years. The extension allows for controlling the contents of the page based on a Python style expression and properties from conf.py. In each of the conf.py files there is the project property which is the name of the site. That makes it pretty useful to use in the ifconfig directive. There are 232 uses of [site wiki=...] in the common directory right now and I expect all of them could be replaced by this directive. It should speed up building some, but I haven't checked how much yet. Should also make incremental builds easier to attain.
https://www.sphinx-doc.org/en/master/usage/extensions/ifconfig.html
I tried searching if this had been brought up before or what Hamish might have intended with include the extension, but nothing turned up.