Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki: First draft of Hitec UAVCAN Servo documentation #2985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoshWelsh
Copy link
Contributor

No description provided.

@JoshWelsh JoshWelsh changed the title Wiki: First draft of Hitec UAVCAN documentation Wiki: First draft of Hitec UAVCAN Servo documentation Aug 26, 2020
Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few formatting thing...also needs a toc entry and listing on UAVCAN periphs page....I will push a commit (non forced) that you can merge and use as template for some fixes....I did not convert all the parm links
havent reviewed for content understand-ability yet....will do that later today perhaps...

- press [Save]
.. image:: ../../images/hitec-uavcan-servos-config2b.png
:width: 450px

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image does not exist


After connecting to ArduPilot, the following parameter changes are required:

``CAN_D1_PROTOCOL`` =1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these should be param hyperlinks instead of shadowboxed...and single spaced bullet lists

- check the checkbox for Stream Mode, select the pull down to enable streaming, and press the [SET] button next to it
- check the checkbox for Stream Time[ms] and enter 20 (you can set this to whatever value works for your system, 20ms is 50hz logging rate), and press [SET] next to it
- press [Save]
.. image:: ../../images/hitec-uavcan-servos-config2b.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need blank line after any list

:width: 450px

3. In the “SERVO Configuration” area in the top right section of the app, press [All] to select all the check boxes on that tab, and press the [READ] button to read those values from the servo in to the app
4. The next step is to enter some configurations for this servo. For the purposes of this exercise, this documentation assumes this servo will be “Servo 2” in ArduPilot. It will also assume ArduPilot is on the bus as Node ID 10, which is ArduPilot's default UAVCAN configuration. These instructions also assume you want a data stream rate of 50Hz but you can change this to suit your requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need blank line after enumerated list

@rmackay9
Copy link
Contributor

great to see this!

@Hwurzburg
Copy link
Contributor

@JoshWelsh any updates?

@JoshWelsh
Copy link
Contributor Author

@JoshWelsh any updates?

Hey @Hwurzburg I think I'm going to need to take you up on your offers for assistance. I got stuck with a technical/formatting issue and then forgot to come back to it. I need to get it pushed though. Can I try to reach out to you Tuesday or Wednesday for assistance?

@Hwurzburg
Copy link
Contributor

Back in town Thursday

@Hwurzburg Hwurzburg force-pushed the pr-hitec-uavcan-servos branch from 5c77d3e to 835562b Compare May 7, 2021 13:15
@Hwurzburg
Copy link
Contributor

Hwurzburg commented May 7, 2021

@JoshWelsh Josh, before doing an in-depth review, I have corrected some build errors, rebased, squashed, and pushed it back to you branch....remaining build errors have to do with missing images still:
WARNING: image file not readable: docs/../../../images/hitec-uavcan-servos-DPC-CAN-servo-power.JPEG
WARNING: image file not readable: docs/../../../images/hitec-uavcan-servos-config2b.png

you also have at least one image file added that is not referenced and should be removed...once that is done, I will re-review....

thanks

@Hwurzburg Hwurzburg force-pushed the pr-hitec-uavcan-servos branch from 835562b to a9b0969 Compare May 7, 2021 13:23
@Hwurzburg
Copy link
Contributor

@JoshWelsh still missing images

@Hwurzburg
Copy link
Contributor

@JoshWelsh any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants