Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev sitl-simulator-software-in-the-loop: update illustration #1764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vierfuffzig
Copy link
Contributor

@vierfuffzig vierfuffzig commented Jun 2, 2019

implements #1432 ping @khancyr

@khancyr
Copy link
Contributor

khancyr commented Jun 2, 2019

Hello, thank for trying to fix this. But the new version is not true. We don't have udp connexion between sitl default backend and SITL vehicle code ...
I got new illustration for SITL, I need to find some time to submit them

@vierfuffzig
Copy link
Contributor Author

thanks @khancyr maybe just up and link your image somwhere and i'll submit and PR to wiki if that helps?

@brunoolivieri
Copy link
Collaborator

Hi @kd0aij

Did you find the illustration?

If not, please, which UDP connection is not correct? Could you point here on http://www.olivieri.com.br/downloads/ArdupilotSoftwareintheLoopSITL.jpg ?

@kd0aij
Copy link
Contributor

kd0aij commented Aug 20, 2019 via email

@brunoolivieri
Copy link
Collaborator

My bad! Sorry @kd0aij

I mean @khancyr , please, which UDP connection is not correct? Could you point here on http://www.olivieri.com.br/downloads/ArdupilotSoftwareintheLoopSITL.jpg ?

@peterbarker
Copy link
Contributor

@khancyr was referring to the edges for port 5502 and 5501.

ArduPilot sends to JSBSim on port 5505 and received on 5504 (https://github.com/ardupilot/ardupilot/blob/master/libraries/SITL/SIM_JSBSim.cpp#L63)

SIM_Aircraft and friends are not currently external to ArduPilot - we interact in a rather more direct manner with them.

ArduPilot sends directly to FlightGear on port 5503

I've no idea what the extra 5501 edge is from "mavproxy on telemetry port" to ArduCopter.

Having the port 14550 coming from the MAVProxy on port 5763 is quite possibly the case - but most of the time it would be from a MAVProxy on 5760.

Having the source ports and destination ports present in these diagrams may not be accurate - I'd have to research a bit to determine that (so I suggest they could stay at least in the short term).

There are several interesting bits missing, too - where our newer simulation backends plug in, for example.

@rajat2004
Copy link
Contributor

rajat2004 commented Sep 9, 2019

Another thing, just pointing it out, most of the newer SITL interfaces (at least all the ones implementing the set_interface_ports function) use ports 9001 & 9002 by default
https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_SITL/SITL_cmdline.cpp#L184

There's also no block in the current illustration where the external Physics engine will connect to the SITL backend in Ardupilot
I think the "Physics Simulation" block should actually be the "Physics Engine" and the SIM_Aircraft.cpp, SIM_Multicopter.cpp can be moved to the ArduCopter.elf block

@brunoolivieri
Copy link
Collaborator

Thanks!

So it is not just a matter of a small cut/paste. I will try to create something from zero and propose.

@rajat2004
Copy link
Contributor

This one might be interesting - #911

@khancyr
Copy link
Contributor

khancyr commented Sep 11, 2019

I will provide some graph I have already done tomorrow.

@brunoolivieri
Copy link
Collaborator

Thanks!

@Hwurzburg
Copy link
Contributor

@khancyr Pierre, still waiting on the graph...

@albcem
Copy link

albcem commented Jun 29, 2020

The long awaited graph would indeed be helpful but may be there is a more direct answer to the problem I am dealing with:

I am trying to implement an upgrade for ArduPlane SITL with Jsbsim and Flightgear. The improved feature is visible moving control surfaces during the SITL simulation and some added RC channels.,I went as far as making it work but then somehow the terrain interaction broke: the aircraft initiates below the terrain.

Here is a link to the thread explaining better what I have done:

https://discuss.ardupilot.org/t/sitl-sim-vehicle-py-aircraft-starts-below-terrain/58369.

Any insight will be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants