-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create endpoints to add, update, and deactivate a product #215
create endpoints to add, update, and deactivate a product #215
Conversation
HubertWojcik10
commented
Oct 4, 2023
- issue here
- I don't know whether I should follow the minimalistic coding approach from AddProduct or the logging approach and many if statements from UpdateProduct
- looking forward to many comments which we can discuss on Thursday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the branch & format files. The GitHub Actions checks fail on the formatting steps. I believe you can run dotnet-format /coffeecard
to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good direction, but changes are needed
coffeecard/CoffeeCard.WebApi/Controllers/v2/ProductsController.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.WebApi/Controllers/v2/ProductsController.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/InitiateProductRequest.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/InitiateProductResponse.cs
Outdated
Show resolved
Hide resolved
...ard/CoffeeCard.Models/DataTransferObjects/v2/Product/InitiateProductRequestWithUserGroups.cs
Outdated
Show resolved
Hide resolved
…n do that using the updateProduct method
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #215 +/- ##
==========================================
- Coverage 7.96% 7.90% -0.07%
==========================================
Files 160 163 +3
Lines 10051 10129 +78
Branches 460 461 +1
==========================================
Hits 801 801
- Misses 9232 9310 +78
Partials 18 18
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First set of comments
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/AddProductRequest.cs
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/ProductResponse.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/ProductResponse.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.WebApi/Controllers/v2/ProductsController.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.WebApi/Controllers/v2/ProductsController.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/AddProductRequest.cs
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/AddProductRequest.cs
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/UpdateProductRequest.cs
Show resolved
Hide resolved
…eating-changing-deactivating-product merge main to get the newest changes in ProductsController
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm