Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create endpoints to add, update, and deactivate a product #215

Merged

Conversation

HubertWojcik10
Copy link
Contributor

  • issue here
  • I don't know whether I should follow the minimalistic coding approach from AddProduct or the logging approach and many if statements from UpdateProduct
  • looking forward to many comments which we can discuss on Thursday

@ghost
Copy link

ghost commented Oct 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

marfavi
marfavi previously requested changes Oct 4, 2023
Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the branch & format files. The GitHub Actions checks fail on the formatting steps. I believe you can run dotnet-format /coffeecard to fix this.

Copy link
Member

@TTA777 TTA777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good direction, but changes are needed

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (d698e8e) 7.96% compared to head (17cf26f) 7.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #215      +/-   ##
==========================================
- Coverage     7.96%   7.90%   -0.07%     
==========================================
  Files          160     163       +3     
  Lines        10051   10129      +78     
  Branches       460     461       +1     
==========================================
  Hits           801     801              
- Misses        9232    9310      +78     
  Partials        18      18              
Files Coverage Δ
...ansferObjects/v2/Product/ChangedProductResponse.cs 0.00% <0.00%> (ø)
...ataTransferObjects/v2/Product/AddProductRequest.cs 0.00% <0.00%> (ø)
...TransferObjects/v2/Product/UpdateProductRequest.cs 0.00% <0.00%> (ø)
...eeCard.WebApi/Controllers/v2/ProductsController.cs 0.00% <0.00%> (ø)
...d/CoffeeCard.Library/Services/v2/ProductService.cs 16.27% <0.00%> (-30.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jonasanker jonasanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set of comments

Copy link

sonarqubecloud bot commented Nov 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
23.2% 23.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@TTA777 TTA777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TTA777 TTA777 enabled auto-merge (squash) November 2, 2023 17:44
@TTA777 TTA777 dismissed stale reviews from jonasanker and marfavi November 2, 2023 17:44

Away in Germany

@TTA777 TTA777 merged commit 6b84d47 into develop Nov 2, 2023
6 of 7 checks passed
@TTA777 TTA777 deleted the shifty-endpoint-creating-changing-deactivating-product branch November 2, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants