Split plugin enabled/disabled into own classes

AmpersandHQ · Aug 4, 2023 · a37b279 · a37b279
1 parent 775010d
commit a37b279
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/dev/phpunit/unit/Ampersand/PatchHelper/Checks/ClassPluginPhpTest.php b/dev/phpunit/unit/Ampersand/PatchHelper/Checks/ClassPluginPhpTest.php
@@ -174,7 +174,7 @@ public function testClassPluginsOnDeletedClass()
         $this->assertEmpty($infos, 'We should have no info level items');
         $this->assertNotEmpty($warnings, 'We should have a warning');
         $expectedWarnings = [
-            'Plugin' => [
+            'Plugin Disabled' => [
                 'Some_Plugin_Class_On_Delete_Target::beforeGetUpdatedAt',
                 'Some_Plugin_Class_On_Delete_Target::afterGetUpdatedAt',
                 'Some_Plugin_Class_On_Delete_Target::aroundGetUpdatedAt',
@@ -243,7 +243,7 @@ public function testClassPluginsOnCreatedClass()
         $this->assertEmpty($infos, 'We should have no info level items');
         $this->assertNotEmpty($warnings, 'We should have a warning');
         $expectedWarnings = [
-            'Plugin' => [
+            'Plugin Enabled' => [
                 'Some_Plugin_Class_On_Created_Target::beforeGetUpdatedAt',
                 'Some_Plugin_Class_On_Created_Target::afterGetUpdatedAt',
                 'Some_Plugin_Class_On_Created_Target::aroundGetUpdatedAt',

diff --git a/src/Ampersand/PatchHelper/Checks.php b/src/Ampersand/PatchHelper/Checks.php
@@ -11,6 +11,8 @@ class Checks
     public const TYPE_PREFERENCE_REMOVED = 'Preference Removed';
     public const TYPE_PREFERENCE = 'Preference';
     public const TYPE_METHOD_PLUGIN = 'Plugin';
+    public const TYPE_METHOD_PLUGIN_DISABLED = 'Plugin Disabled';
+    public const TYPE_METHOD_PLUGIN_ENABLED = 'Plugin Enabled';
     public const TYPE_DB_SCHEMA_ADDED = 'DB schema added';
     public const TYPE_DB_SCHEMA_CHANGED = 'DB schema changed';
     public const TYPE_DB_SCHEMA_REMOVED = 'DB schema removed';
@@ -41,5 +43,7 @@ class Checks
         self::TYPE_SETUP_PATCH_SCHEMA,
         self::TYPE_SETUP_SCRIPT,
         self::TYPE_METHOD_PLUGIN,
+        self::TYPE_METHOD_PLUGIN_DISABLED,
+        self::TYPE_METHOD_PLUGIN_ENABLED,
     ];
 }
diff --git a/src/Ampersand/PatchHelper/Checks/ClassPluginPhp.php b/src/Ampersand/PatchHelper/Checks/ClassPluginPhp.php
@@ -146,13 +146,12 @@ class_exists($areaConfig[$area][$pluginClass]['type'])
                         continue;
                     }
                     if (isset($targetClassMethods) && is_array($targetClassMethods) && !empty($targetClassMethods)) {
-                        // created handling
                         if (isset($targetClassMethods[$methodName])) {
-                            $this->warnings[Checks::TYPE_METHOD_PLUGIN][] = "$nonMagentoPlugin::$method";
+                            $this->warnings[Checks::TYPE_METHOD_PLUGIN_ENABLED][] = "$nonMagentoPlugin::$method";
                         }
                     } else {
                         // deleted handling
-                        $this->warnings[Checks::TYPE_METHOD_PLUGIN][] = "$nonMagentoPlugin::$method";
+                        $this->warnings[Checks::TYPE_METHOD_PLUGIN_DISABLED][] = "$nonMagentoPlugin::$method";
                     }
                 }
             }