Phpstan level 1

.gitignore

@@ -5,3 +5,4 @@ dev/instances/magento*
 dev/vendor/
 dev/phpunit/functional/.phpunit.result.cache
 dev/phpunit/unit/.phpunit.result.cache
+dev/phpstan/vendor

.travis.yml

@@ -18,6 +18,7 @@ install:
   - composer install
 # Run static analysis tests before trying to install the modules in magento
   - composer test:static
+  - composer test:phpstan
 # Run unit tests before trying to install magento
   - composer test:unit
   - if [[ $TEST_GROUP = m22 ]]; then rm -rf composer.lock ./vendor/ ; fi # todo ensure all 22 test cases are covered in 24

composer.json

@@ -26,6 +26,7 @@
     "scripts": {
         "test:static:fix": " vendor/bin/phpcbf --standard=dev/phpcs.xml && vendor/bin/php-cs-fixer fix --diff",
         "test:static": "vendor/bin/phpcs --standard=dev/phpcs.xml -s && vendor/bin/php-cs-fixer fix  --diff --dry-run",
+        "test:phpstan": "dev/phpstan/run.sh",
         "test:unit": "vendor/bin/phpunit -c dev/phpunit/unit/phpunit.xml --verbose"
     }
 }

dev/phpstan/README.md

@@ -0,0 +1,5 @@
+We cannot require dev `magento/framework` into the main tools vendor directory.
+
+This is because it affects the composer autoloading, and this affects the running of the phpunit functional tests.
+
+Because we're only bundling this in for phpstan, silo it off to keep the tool running as-is.

dev/phpstan/composer.json

@@ -0,0 +1,25 @@
+{
+    "name": "ampersand/magento2-upgrade-patch-helper-phpstan-dev-deps",
+    "description": "Phpstan dev dependencies, so they do not mess with the autoloader of the actual tooling which is very important",
+    "repositories": [
+        {
+            "type": "composer",
+            "url": "https://repo-magento-mirror.fooman.co.nz/"
+        }
+    ],
+    "authors": [
+        {
+            "name": "Luke Rodgers",
+            "email": "[email protected]"
+        }
+    ],
+    "require-dev": {
+        "magento/framework": "*",
+        "phpstan/phpstan": "^1.9"
+    },
+    "config": {
+        "allow-plugins": {
+            "magento/composer-dependency-version-audit-plugin": false
+        }
+    }
+}