Skip to content

Commit

Permalink
Merge pull request #203 from MonkeyKing44/fix-typo
Browse files Browse the repository at this point in the history
Fix typo forkway-loyalty-pool.md
  • Loading branch information
Ivshti authored Jan 30, 2025
2 parents a948f8c + 9f2ebe8 commit b1d922b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion audits/forkway-loyalty-pool.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ Another simple fix would be to tweak `toMint()` so that the base it uses to calc

This is categorized as "low" as the AdEx team has informed us that they would be staking a significant sum of ADX when the pool is deployed, therefore eliminating the likelihood of this exploit.

**AdEx team comment:** we have decided not to honor the `maxTotalADX` in `toMint()` as suggested because, 1) it impacts the APY predictability 2) it will be unfair to pool token holders who've staked early and then their collective share has incresed over `maxTotalADX`. In this scenario of oversubscription, the pool token will be traded above it's value in ADX.
**AdEx team comment:** we have decided not to honor the `maxTotalADX` in `toMint()` as suggested because, 1) it impacts the APY predictability 2) it will be unfair to pool token holders who've staked early and then their collective share has increased over `maxTotalADX`. In this scenario of oversubscription, the pool token will be traded above it's value in ADX.

**Severity:** low

Expand Down

0 comments on commit b1d922b

Please sign in to comment.