Skip to content

Commit

Permalink
Merge pull request #205 from BorisNaum/Fix-typo
Browse files Browse the repository at this point in the history
Update forkway-loyalty-pool.md
  • Loading branch information
Ivshti authored Jan 30, 2025
2 parents 1ab8316 + 273c725 commit 0ade84a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions audits/forkway-loyalty-pool.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ This is the first time we see an ERC20 with an ability to change the `symbol()`.

Suppose ADX is sent directly to the pool contract. At this point the amount of incentive to be minted will increase as if this amount of ADX has been there the entire time since the last `lastMintTime`. Essentially, ADX sent to the contract will automatically incur interest as if it's been deposited when the last `mintIncentive()` happened (triggered by entering/leaving).

Due to the limitations of the ERC20 standard this can't be resolved better than the AdEx team's solution of having a publically callable `mintIncentive()` function. Any automated system that sends ADX to the pool should call `mintIncentive()` first to avoid this.
Due to the limitations of the ERC20 standard this can't be resolved better than the AdEx team's solution of having a publicly callable `mintIncentive()` function. Any automated system that sends ADX to the pool should call `mintIncentive()` first to avoid this.

**Severity:** informational

Expand Down Expand Up @@ -241,4 +241,4 @@ A ADX-LOYALTY/ADX market can be arbitraged through the loyalty contract by excha

**AdEx team comment:** acknowledged; because ADX-LOYALTY is essentially a limited supply token that gives you the right to participate in governance, we believe it's fair that it can trade higher than the underlying ADX if the supply has ran out

**Status:** resolved
**Status:** resolved

0 comments on commit 0ade84a

Please sign in to comment.