Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new slice implicit fun cases, sphere, cyln, box, and plane #1395

Merged
merged 2 commits into from
Oct 9, 2024
Merged

add new slice implicit fun cases, sphere, cyln, box, and plane #1395

merged 2 commits into from
Oct 9, 2024

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Oct 7, 2024

No description provided.

@cyrush cyrush marked this pull request as ready for review October 7, 2024 16:46
@cyrush cyrush requested a review from nicolemarsaglia October 7, 2024 16:46
nicolemarsaglia
nicolemarsaglia approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@nicolemarsaglia nicolemarsaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple of fixes in the unit tests, this looked great!

@cyrush cyrush merged commit c6d5e2e into develop Oct 9, 2024
22 checks passed
@cyrush cyrush deleted the task/2024_09_slice_sphere_and_cyl branch October 9, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolemarsaglia nicolemarsaglia nicolemarsaglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyrush @nicolemarsaglia