Fix state/config loading, test on all PRs and add use case

[5-pebbles]

This PR improves the handling of state and config loading.

[AlexvZyl]

You can change the message if you want, but we are merging this into #113.

[5-pebbles]

sorry, I misread that message.

[5-pebbles]

I resolved conflicts then ran tests locally with act and they are passing.

I figure I should let you merge though if this is what you are looking for.

[AlexvZyl]

No longer need to run the tests locally! :)

[5-pebbles]

Thanks.

[AlexvZyl]

Did you see I started a review?

[5-pebbles]

No, I did not. Quite frankly this is the first project I have tried actually using GitHub for so I don't know any of this stuff.

[5-pebbles]

Yeah, I have no idea what I am supposed to be doing.

[AlexvZyl]

No worries! One step at a time.

I left comments (in this PR UI) on the changes you made. Try and find them and respond to them.

[5-pebbles]

I though comments showed up in this chat, but I don't see any.
I also though they showed up on the Files changed tab but I don't see anything there either.
And it still says pending reviewer.

[5-pebbles]

Ok, I can not see the code review I tested it on a private repo and it should be here but its not.

[AlexvZyl]

Scroll through the "files changed" tab.

[AlexvZyl]

Odd. I will check it out tomorrow.

[5-pebbles]

There are no comments there.

[5-pebbles]

Alright Good Night!

[AlexvZyl]

@5-pebbles You should be able to see the review now.

[5-pebbles]

Yup I can.

[5-pebbles]

I am thinking about separating bg_highlight and bg_visual.

I think bg_highlight makes sense for Search and CodeBlock, plus it was only used into places:

• G.CursorColumn & G.CursorLine

which I would move to using bg_visual

Its value would look something like this.

C.bg_highlight = (options.swap_backgrounds and C.gray0) or C.black1
-- so same as bg_float but without transparency

What do you think?

[5-pebbles]

I don't know why its not showing up in the pr but 4856cf8 contains the proposed changes.

[5-pebbles]

I re-selected fix/state as base to force sync.

[AlexvZyl]

Sure, I think that will work!

[AlexvZyl]

I think we need a better name than bg_highlight. bg_highlight does not make sense for the search bar...

Maybe something like bg_bar? What do you think?

[5-pebbles]

I don't know I think bg_highlight is good, its the a highlighted section of background, eg a search item or code block.

But naming this is really not my forte so I will leave that up to you, but I used it for code blocks as well and bg_bar does not sound right for those.

[AlexvZyl]

Hmm. I don't think we should use black0 for code blocks. Rather black1 or maybe black2.

[5-pebbles]

Agreed and that is already the case:

G.CodeBlock = { bg = C.bg_highlight, fg = C.fg }

C.bg_highlight = (options.swap_backgrounds and C.gray0) or C.black1

[AlexvZyl]

Ah okay I see, but search should be black0.

[AlexvZyl]

Actually, we need bg_statusline and Search should use that.

[5-pebbles]

Alright I will make a commit for that, but it was black1 before and I was just following along with that.

[5-pebbles]

So bg_statusline is none when transparent background is true do you want no search highlight?

What about using bg_visual its the black0 though I would like to make it customizable with something like #100. It might make sense for search to be the same color as visual section.

I also thought it might make sense to have transparent code blocks and I could add those in the same commit.

[5-pebbles]

What do you think about my last comment ^ @AlexvZyl

[AlexvZyl]

Sorry @5-pebbles!

bg_statusline should not be NONE when transparent is enabled.

[AlexvZyl]

Also, with customizability, I want to add two callbacks:

1. To override the base palette before extension.
2. To override the extended colors as well.

But we should do this in a seperate PR.

[AlexvZyl]

The reason I want search to be black0 is because search happens in the bottom bar, so should be black0.

[5-pebbles]

Sorry @5-pebbles!

bg_statusline should not be NONE when transparent is enabled.

Aright I will fix that, because it is NONE on main.

The reason I want search to be black0 is because search happens in the bottom bar, so should be black0.

To make sure we are both on the same page the search highlight is:

I will set it to black0 but its set to black1 on main.
I think it would make sense for it to be bg_visual but I can do that in my own config.

Also would it make sense for code blocks to be transparent with transparent_bg?
I think it would... and if so I think they should be bg_float they would have the same values as on main just with transparency.

I will get to these tomorrow because I have a bunch of other stuff to do today.

[AlexvZyl]

Okay, this entire time I though the search highlight was that highlight that colors the bottom bar, where you type in the search. The bottom bar should be black0, the ones you are referring to should either be a lighter black or some grey, which ever you think looks best.

As for the code blocks being transparent, I am not sure... I think they should be.

[5-pebbles]

Okay, this entire time I though the search highlight was that highlight that colors the bottom bar, where you type in the search. The bottom bar should be black0, the ones you are referring to should either be a lighter black or some grey, which ever you think looks best.

I think they should be bg_visual same as the visual selection (that way they will also change with the light and dark cursorline setting).

As for the code blocks being transparent, I am not sure... I think they should be.

Alright great because I already did that...

[5-pebbles]

If you are okay with those changes I think everything in this pr is done.

[AlexvZyl]

Cool!