Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(highlights): added highlights to @markup tags #110

Closed
wants to merge 2 commits into from
Closed

feat(highlights): added highlights to @markup tags #110

wants to merge 2 commits into from

Conversation

juniorsundar
Copy link
Contributor

@juniorsundar juniorsundar commented Feb 16, 2024

Covers the highlights for @markup tags which means colour highlights are now back in Markdown as well as Neorg.

I used tokyonight.nvim to get the tags that need highlighting, and used the existing flavours (colour allocation) to assign the highlight colours to remain true to the creator's intention with this theme.

@AlexvZyl AlexvZyl self-assigned this Feb 24, 2024
@AlexvZyl AlexvZyl added the Enhancement New feature, request or suggestion label Feb 24, 2024
@AlexvZyl
Copy link
Owner

Awesome, thanks!

Will come back to this after #113.

@AlexvZyl
Copy link
Owner

@juniorsundar Are you able to resolve the merge conflicts? Might be a bit rough.

@juniorsundar
Copy link
Contributor Author

Oh wow! That's a huge refactor!
I think it will be easier to just implement the feature additions into the current state of main than to spend time resolving these merge conflicts.
Unless you are already planning to address the highlight groups I've added, you can close this PR and I'll just open a new one by pulling from main and adding the highlight groups to that.

@AlexvZyl
Copy link
Owner

You can open a new PR if you want? Otherwise I will do it.

@juniorsundar
Copy link
Contributor Author

I'll leave that decision up to you.
I have very little confidence in my ability to resolve merge conflicts with git without accidentally causing the world to revert to a prehistoric commit.

@AlexvZyl
Copy link
Owner

Ok let's close this one then you make a new PR. I want you to have the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature, request or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants