feat(cursorline)!: add cursorline bg option for visual selection color

[5-pebbles]

closes #100

• Add cursorline.bg option with default value of "#191D24".
• Remove cursorline.theme option.
• Update docs to reflect new defaults.

BREAKING CHANGE: cursorline.theme option removed, replaced by cursorline.bg.

[5-pebbles]

Some time this week, I will create another pull request to allow use of the palette in default options.

[5-pebbles]

Oops it breaks if there is a transparent background, I don't know how those work so give me a while an I will fix it.

[5-pebbles]

Okay, I can't figure out how lua/nordic/colors/init.lua handles transparent backgrounds.

I will try to figure it out tomorrow, but for now this whole thing don't work.

    C.bg = (O.transparent_bg and C.none) or C.gray0

    -- Diffs
    C.diff = {
        change0 = U.blend(C.blue1, C.bg, 0.05),
        change1 = U.blend(C.blue2, C.bg, diff_blend),
        add = U.blend(C.green.base, C.bg, diff_blend),
        delete = U.blend(C.red.base, C.bg, diff_blend),
    }

[5-pebbles]

Does it work?
When I change the default on my local clone of the main, I get the same error as my fork...

[5-pebbles]

After #103 it should pass tests.

[AlexvZyl]

So it the test actually failed with that bug? Odd, it did not fail on main.

[5-pebbles]

I changed where the options are imported, in mine they are re-imported with each call of setup, I don't really know how Lua imports work but my guess is that they weren't being applied on the second run of setup() in the tests.

[AlexvZyl]

Ah. The options have to be re-imported when extending the palette. Nice catch

[AlexvZyl]

I also want to add callbacks for pre and post extension, but we can do that in a different PR.

[AlexvZyl]

Actually, I am still confused. When you call require, a reference is returned. I will check when I am back form vacation

[5-pebbles]

When I print the options in extend_palette I get the same values for each of the tests.

This pull request should fix that though, accidentally...

Main output:

ts_context = table: 0x7f5cf5e26828
on_palette = function: 0x7f5cf5e263f8
transparent_bg = false
reduced_blue = true
cursorline = table: 0x7f5cf5e26470
swap_backgrounds = false
override = table: 0x7f5cf5e26428
bright_border = false
bold_keywords = false
italic_comments = true
leap = table: 0x7f5cf5e267a8
telescope = table: 0x7f5cf5e26728
noice = table: 0x7f5cf5e266a8

ts_context = table: 0x7f5cf5e26828
on_palette = function: 0x7f5cf5e263f8
transparent_bg = false
reduced_blue = true
cursorline = table: 0x7f5cf5e26470
swap_backgrounds = false
override = table: 0x7f5cf5e26428
bright_border = false
bold_keywords = false
italic_comments = true
leap = table: 0x7f5cf5e267a8
telescope = table: 0x7f5cf5e26728
noice = table: 0x7f5cf5e266a8 

This PR:

swap_backgrounds = false
on_palette = function: 0x7f10031be4b0
ts_context = table: 0x7f1002904758
leap = table: 0x7f10029048d8
reduced_blue = false
cursorline = table: 0x7f1002904a58
transparent_bg = true
override = table: 0x7f1002904ba0
noice = table: 0x7f1002905768
bright_border = false
italic_comments = true
bold_keywords = false
telescope = table: 0x7f10029055e8

swap_backgrounds = true
on_palette = function: 0x7f1002977268
ts_context = table: 0x7f1002909c80
transparent_bg = false
reduced_blue = true
cursorline = table: 0x7f100290a100
telescope = table: 0x7f100290b290
override = table: 0x7f100290a308
noice = table: 0x7f100290b4d0
italic_comments = false
bright_border = true
bold_keywords = true
leap = table: 0x7f1002909ec0

[5-pebbles]

reverted fix that can be implemented in #105 or a similar pr.

[5-pebbles]

Its a good thing you didn't get to merging this because it was broken...

But it should be fixed now.

[5-pebbles]

Also it closes #108 due to change in where the options are imported

[AlexvZyl]

Let's come back to this ater #113!

[5-pebbles]

I am closing this in favor of a more general solution to changing the palette & extended palette.