Skip to content
This repository has been archived by the owner on Feb 10, 2025. It is now read-only.

Commit

Permalink
Simpliefied logging + restored json formatter
Browse files Browse the repository at this point in the history
  • Loading branch information
Filip committed Sep 29, 2017
1 parent 3833909 commit 93110dc
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 19 deletions.
2 changes: 1 addition & 1 deletion lambda/forwarder.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func CreateForwarder(entry config.AmazonEntry, lambdaClient ...lambdaiface.Lambd
client = lambda.New(session.Must(session.NewSession()))
}
forwarder := Forwarder{entry.Name, client, entry.Target}
log.WithFields(log.Fields{"forwarderName": forwarder.Name()}).Info("Created forwarder")
log.WithField("forwarderName", forwarder.Name()).Info("Created forwarder")
return forwarder
}

Expand Down
2 changes: 1 addition & 1 deletion mapping/mapping.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func (c Client) Load() (map[consumer.Client]forwarder.Client, error) {

func (c Client) loadFile() ([]byte, error) {
filePath := os.Getenv(config.MappingFile)
log.WithFields(log.Fields{"mappingFile": filePath}).Info("Loading mapping file")
log.WithField("mappingFile", filePath).Info("Loading mapping file")
return ioutil.ReadFile(filePath)
}

Expand Down
12 changes: 4 additions & 8 deletions rabbitmq/consumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,12 @@ func closeRabbitMQ(conn *amqp.Connection, ch *amqp.Channel) {
log.Info("Closing RabbitMQ connection and channel")
if ch != nil {
if err := ch.Close(); err != nil {
log.WithFields(log.Fields{
"error": err.Error()}).Error("Could not close channel")
log.WithField("error", err.Error()).Error("Could not close channel")
}
}
if conn != nil {
if err := conn.Close(); err != nil {
log.WithFields(log.Fields{
"error": err.Error()}).Error("Could not close connection")
log.WithField("error", err.Error()).Error("Could not close connection")
}
}
}
Expand Down Expand Up @@ -180,11 +178,9 @@ func (c Consumer) startForwarding(params *workerParams) error {
}
}
case <-params.check:
log.WithFields(log.Fields{
"forwarderName": forwarderName}).Info("Checking")
log.WithField("forwarderName", forwarderName).Info("Checking")
case <-params.stop:
log.WithFields(log.Fields{
"forwarderName": forwarderName}).Info("Closing")
log.WithField("forwarderName", forwarderName).Info("Closing")
closeRabbitMQ(params.conn, params.ch)
return errors.New(closedBySupervisorMessage)
}
Expand Down
8 changes: 3 additions & 5 deletions server.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,16 @@ import (
)

func main() {
log.SetFormatter(&log.TextFormatter{})
log.SetFormatter(&log.JSONFormatter{})
log.SetOutput(os.Stdout)

consumerForwarderMap, err := mapping.New().Load()
if err != nil {
log.WithFields(log.Fields{
"error": err.Error()}).Fatalf("Could not load consumer - forwarder pairs. Error: " + err.Error())
log.WithField("error", err.Error()).Fatalf("Could not load consumer - forwarder pairs")
}
supervisor := supervisor.New(consumerForwarderMap)
if err := supervisor.Start(); err != nil {
log.WithFields(log.Fields{
"error": err.Error()}).Fatal("Could not start supervisor")
log.WithField("error", err.Error()).Fatal("Could not start supervisor")
}
http.HandleFunc("/restart", supervisor.Restart)
http.HandleFunc("/health", supervisor.Check)
Expand Down
2 changes: 1 addition & 1 deletion sns/forwarder.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func CreateForwarder(entry config.AmazonEntry, snsClient ...snsiface.SNSAPI) for
client = sns.New(session.Must(session.NewSession()))
}
forwarder := Forwarder{entry.Name, client, entry.Target}
log.WithFields(log.Fields{"forwarderName": forwarder.Name()}).Info("Created forwarder")
log.WithField("forwarderName", forwarder.Name()).Info("Created forwarder")
return forwarder
}

Expand Down
2 changes: 1 addition & 1 deletion sqs/forwarder.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func CreateForwarder(entry config.AmazonEntry, sqsClient ...sqsiface.SQSAPI) for
client = sqs.New(session.Must(session.NewSession()))
}
forwarder := Forwarder{entry.Name, client, entry.Target}
log.WithFields(log.Fields{"forwarderName": forwarder.Name()}).Info("Created forwarder")
log.WithField("forwarderName", forwarder.Name()).Info("Created forwarder")
return forwarder
}

Expand Down
3 changes: 1 addition & 2 deletions supervisor/supervisor.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ func (c *Client) Check(w http.ResponseWriter, r *http.Request) {
if accept := r.Header.Get(acceptHeader); accept != "" &&
!strings.Contains(accept, jsonType) &&
!strings.Contains(accept, acceptAll) {
log.WithFields(log.Fields{
"acceptHeader": accept}).Warn("Wrong Accept header")
log.WithField("acceptHeader", accept).Warn("Wrong Accept header")
notAcceptableResponse(w)
return
}
Expand Down

0 comments on commit 93110dc

Please sign in to comment.