forked from WebKit/WebKit
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sync
input
specific unicode-bidi rendering from Web Specification
https://bugs.webkit.org/show_bug.cgi?id=285252 rdar://142191490 Reviewed by NOBODY (OOPS!). This patch aligns WebKit with Web Specification [1]: [1] https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering This patch implements `input` specific rules for directionality being `auto` and move `textarea` and `pre` rules in UA stylesheet. The rationale is that `is:` can be lead to performance concern, so did the change in C++, it also matches Blink / Chromium. Despite aligning with specification, there is still ambiguity on how to deal with `password` and `text` input types for which following issue is raised [2]. [2] whatwg/html#10896 * Source/WebCore/css/html.css: (textarea[dir=auto i], pre[dir=auto i]): * Source/WebCore/html/HTMLElement.cpp: (WebCore::unicodeBidiAttributeForDirAuto): * LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules-expected.txt: Rebaselined (WebCore::HTMLElement::collectPresentationalHintsForAttribute):
- Loading branch information
1 parent
70d6fcb
commit e1e6a10
Showing
3 changed files
with
12 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters