-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GPU Support #30
base: develop
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…gin into gpu-support
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #30 +/- ##
===========================================
- Coverage 96.66% 96.42% -0.24%
===========================================
Files 3 3
Lines 270 280 +10
===========================================
+ Hits 261 270 +9
- Misses 9 10 +1 ☔ View full report in Codecov by Sentry. |
Thanks a lot for this @dhroth ! This is super helpful, we've been meaning to add GPU support to this one for some time now. While we review this, do you mind creating an issue for this with a brief explanation of the added support if possible? Maybe even adding a small example workflow that you tried which was failing for you earlier but works after you added the GPU support. Would help us tremendously in keeping track of things 😅 . You can then attach this PR to that issue as well. Again, thanks a lot and please feel free to ask here if you have any questions! |
Solves #34 |
Hey, glad it's helpful! Sorry I was unresponsive for the last week. I see @santoshkumarradha has made an issue for this. Let me know if there's anything else that needs doing on this! |
I've added support to GCPBatchExecutor for launching jobs with GPUs. I updated existing tests to account for the new functionality, but I wasn't sure whether I should add any new tests. I've tested it with GCP and have been able to submit jobs that launch VMs with a T4 GPU. I followed https://github.com/AgnostiqHQ/covalent-awsbatch-plugin/blob/develop/covalent_awsbatch_plugin/awsbatch.py, but also added the option to choose which GPU you want. I've attempted to follow the contributing guidelines, but please let me know if I missed anything!