Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GPU Support #30

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Adding GPU Support #30

wants to merge 10 commits into from

Conversation

dhroth
Copy link

@dhroth dhroth commented Nov 20, 2023

I've added support to GCPBatchExecutor for launching jobs with GPUs. I updated existing tests to account for the new functionality, but I wasn't sure whether I should add any new tests. I've tested it with GCP and have been able to submit jobs that launch VMs with a T4 GPU. I followed https://github.com/AgnostiqHQ/covalent-awsbatch-plugin/blob/develop/covalent_awsbatch_plugin/awsbatch.py, but also added the option to choose which GPU you want. I've attempted to follow the contributing guidelines, but please let me know if I missed anything!

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0255a93) 96.66% compared to head (9622973) 96.42%.

Files Patch % Lines
covalent_gcpbatch_plugin/gcpbatch.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
- Coverage    96.66%   96.42%   -0.24%     
===========================================
  Files            3        3              
  Lines          270      280      +10     
===========================================
+ Hits           261      270       +9     
- Misses           9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kessler-frost
Copy link
Member

kessler-frost commented Dec 6, 2023

Thanks a lot for this @dhroth ! This is super helpful, we've been meaning to add GPU support to this one for some time now. While we review this, do you mind creating an issue for this with a brief explanation of the added support if possible? Maybe even adding a small example workflow that you tried which was failing for you earlier but works after you added the GPU support. Would help us tremendously in keeping track of things 😅 . You can then attach this PR to that issue as well.

Again, thanks a lot and please feel free to ask here if you have any questions!

@santoshkumarradha
Copy link
Member

Solves #34

@santoshkumarradha santoshkumarradha linked an issue Dec 11, 2023 that may be closed by this pull request
@dhroth
Copy link
Author

dhroth commented Dec 13, 2023

Hey, glad it's helpful! Sorry I was unresponsive for the last week. I see @santoshkumarradha has made an issue for this. Let me know if there's anything else that needs doing on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GPU Instances in GCP Batch Plugin
4 participants