Feature/url query apply data okodayon #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatherCandidates内で行われていた不要なfor文を削除。それに伴いfor分の削除と、postかgetの条件式を変更。
fullscan語にmessageがIssueを空にし、candidateが埋まっているsitemapをダウンロードできます。それをImportしてQuickScanをすることにより、2回目以降にgatherをせずにstoredを見つけることができる。
hrefなどタグ内のURLは今まで元のURLにくっつけて送信するだけだったが、そこにランダムなcsrfトークンなどが含まれた場合に、無限ループに陥る可能性がある。そこで、applyDataと関連付けることにより、applyDataに入力された値をQueryに入れるようになり、ランダムなcsrfトークンなどによる無限ループを回避できる。
y0d3n
reviewed
Dec 1, 2021
Comment on lines
+56
to
+69
| func EmptySitemapIssue(node *JsonNode) { | ||
| for i := 0; len(node.Children) > i; i++ { | ||
| EmptySitemapIssue(&node.Children[i]) | ||
| } | ||
|
|
||
| node.Issue = nil | ||
| /* | ||
| for i, _ := range node.Children { | ||
| EmptySitemapIssue(&node.Children[i]) | ||
| } | ||
| node.Issue = nil | ||
| */ | ||
|
|
||
| } |
There was a problem hiding this comment.
これはsitemap packageのjson.goとかの方がよさそう
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
applyDataを参照するようになりました。関連するIssue
#118
変更点
チェック項目
再現手順
http://192.168.xxx.xxx/wavsep/active/Reflected-XSS/RXSS-Detection-Evaluation-GET-Experimental/index.jsp↑のページにあるCase06のhrefに
userinputというGETパラメーターがあるので、crawl.vueのパラメーター追加を行ってみてください。結果は
/api/sitemapでGETparamの欄を確認することができるかと思います。