ActiveRecord queries with includes now respect :with_deleted => true #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values of the result hash are all reflection objects. Adding a boolean there breaks stuff.
Remove #unscoped to avoid clearing the where_values prematurely.
The dependent destroy callback mechanism in Rails calls destroy! instead of destroy for has_many associations. With the existing implementation of acts_as_paranoid, this would unintentionally cause dependent objects to be hard-destroyed. This change makes destroy and destroy! identical, and adds a separate destroy_fully! method for full destroy.
By merging the scope, the original code would re-apply the default non-deleted scope, causing the scope to always return zero records. Use regular scope chaining instead.
This is to avoid conflict with minitest versions required by the different versions of Rails.
|
@pelargir Could you rebase this? Thanks! |
|
I couldn't get it to merge properly so I created pull request #37 instead. Please use that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #17 by ensuring :with_deleted => true is respected when using #includes and #joins in association queries. Hat tip to @tkupari for the original fix in goncalossilva/acts_as_paranoid#115