Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type annotations and docstrings to devlib #715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arjpur01
Copy link

Most of the files are covered, but some of the
instruments and unused platforms are not augmented Minimum Python version required change from 3.7 to 3.10 in order to support some of the annotation features

@marcbonnici
Copy link
Collaborator

Hi,

If this requires changing the minimum supported Python version that means we need to perform a new release of both devlib and the WA project on github and PyPI before we can merge this PR.

We should also check with our known users what version of Python they are currently using to ensure we provide sufficient time for any users to migrate if required before dropping support for < 3.10.

Most of the files are covered, but some of the
instruments and unused platforms are not augmented
@arjpur01
Copy link
Author

Hi,

If this requires changing the minimum supported Python version that means we need to perform a new release of both devlib and the WA project on github and PyPI before we can merge this PR.

We should also check with our known users what version of Python they are currently using to ensure we provide sufficient time for any users to migrate if required before dropping support for < 3.10.

Hi Marc,

My changes dont exactly need the 3.10 version. I have modified now, to avoid the explicit dependency on the newer language features, for ex - changing imports of Literal, Protocol and TypedDict from typing_extensions instead of from typing.
I have reverted the setup.py change to move up to 3.10 in this PR.
I have validated on bench to use 3.7, 3.8, 3.9 and 3.10 python versions with this changes.

Still i think it is something we should pursue and move up to 3.10 in near future, but that effort can be taken up independent of this PR.

Kindly review my changes and do the needful.

Thanks and Regards,
Arjun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants