Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design, Feat: SocialView에 카카오 로그인 기능 연결, SocialDetailView, SocialView Design 수정 #81

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Design, Feat: SocialView에 카카오 로그인 기능 연결, SocialDetailView, SocialView Design 수정 #81

merged 6 commits into from
Dec 14, 2023

Conversation

Eunice0927
Copy link
Collaborator

@Eunice0927 Eunice0927 commented Dec 14, 2023 •
edited
Loading

🔐 close #83 #84 #85 #86

작업사항

  • SocialView에서 로그인하기 버튼을 누르면 카카오 로그인 API가 연결된다.
  • SocialDetailView의 응원, 재촉 버튼 색을 변경했다.
  • HomeModalView의 색상이 반대로 설정 된 것을 수정했다.
  • SocialView의 Title 크기와 위치를 변경했다.

향후 작업예정

  • 소셜 디테일뷰에 하고싶으면, 해야하면 색상이 반대로 나오는 이슈 해결이 필요합니다.

스크린샷

작업 전 작업 후
스크린샷 2023-12-14 오전 10 46 04 스크린샷 2023-12-14 오후 8 51 49
스크린샷 2023-12-14 오전 10 46 14 스크린샷 2023-12-14 오후 8 51 53
스크린샷 2023-12-13 오전 10 57 18 스크린샷 2023-12-14 오후 8 51 58
스크린샷 2023-12-14 오후 8 52 18
스크린샷 2023-12-14 오후 8 52 23

hjsupernova
hjsupernova approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@hjsupernova hjsupernova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Eunice0927 Eunice0927 merged commit 10cd578 into dev Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjsupernova hjsupernova hjsupernova approved these changes

@lm-loki lm-loki lm-loki approved these changes

Assignees
No one assigned
Labels
🎨 Design 🔮 eunice ✨ feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eunice0927 @hjsupernova @lm-loki