Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds missing version 3.0.4 and 3.1.1 #264

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: adds missing version 3.0.4 and 3.1.1 #264

merged 1 commit into from
Jan 7, 2025
+5 −3

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Dec 31, 2024 •
edited
Loading

fixes microsoft/kiota#5944

Motivation

OAS 3.1.1 and 3.0.4 were released as maintenance releases and don't change anything from a functional perspective.

We're starting to see those new versions show up in OAS documents, and this library is failing to parse them simply based on the version number.

Changes

  • adds 3.0.4 to the list of supported versions.
  • adds 3.1.1 to the list of supported versions.
  • moves the version arrays to constants to avoid allocating an array on each call.

@baywet baywet mentioned this pull request Dec 31, 2024
Closed
@SLdragon SLdragon mentioned this pull request Jan 6, 2025
Closed
@philsturgeon philsturgeon enabled auto-merge January 7, 2025 08:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12559562338

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.149%
Totals Coverage Status
Change from base Build 11334801444: 0.03%
Covered Lines: 281
Relevant Lines: 292
💛 - Coveralls

@philsturgeon philsturgeon disabled auto-merge January 7, 2025 08:15
@philsturgeon philsturgeon merged commit 3c907d7 into APIDevTools:main Jan 7, 2025
6 checks passed
@baywet baywet deleted the fix/missing-version-304-and-311 branch January 7, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsturgeon philsturgeon philsturgeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openapi spec generated by Kiota is in version 3.0.4
3 participants
@baywet @coveralls @philsturgeon