Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done with changes #1646 , #1644 #1667

Closed
wants to merge 10 commits into from
Closed

Conversation

Ashmitha2606
Copy link
Contributor

@Ashmitha2606 Ashmitha2606 commented Nov 4, 2024

issue: #1644 and #1646
Description: changed profile icon for all pages and change the whole ui of blog page added hovering to buttons created cards to the elements changed completely a new look
before the change
Screenshot 2024-11-03 172718
Screenshot 2024-11-03 172730
Screenshot 2024-11-03 173416
Screenshot 2024-11-03 173424
after the change
Screenshot 2024-11-04 161113
Screenshot 2024-11-04 161126
Screenshot 2024-11-04 161137
Screenshot 2024-11-04 161146
Screenshot 2024-11-04 161157
Screenshot 2024-11-04 161209

Pull Request Checklist

  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .

@Ashmitha2606
Copy link
Contributor Author

Ashmitha2606 commented Nov 4, 2024

@ANSHIKA-26 check it
since i have completed 2 issues can u award level 3

@Ashmitha2606 Ashmitha2606 changed the title done with changes done with changes #1646 , #1644 Nov 4, 2024
Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
word-wise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:30am

@hiteashgupta1
Copy link
Collaborator

hiteashgupta1 commented Nov 5, 2024

Check the colour in light mode improve it

@Ashmitha2606
Copy link
Contributor Author

@hiteashgupta1 is it for leading blog page

@hiteashgupta1
Copy link
Collaborator

hiteashgupta1 commented Nov 5, 2024

Yes do the changes

@ANSHIKA-26
Copy link
Owner

image
why does the leading blog page has this ?

@ANSHIKA-26
Copy link
Owner

@Ashmitha2606 undo all the changes you did to leading blog page

@ANSHIKA-26
Copy link
Owner

rest is fine , will merge , i cannot give you a level 3 for 2 level 1 issues , i will be giving level 2 for this PR , thanks !
level 3 is for when you work on backend as well or do some major changes

@Ashmitha2606
Copy link
Contributor Author

Ashmitha2606 commented Nov 6, 2024

@ANSHIKA-26 done with the changes

@ANSHIKA-26
Copy link
Owner

this is how blog.html looks like in light mode
image
the buttons are barely visible

@Ashmitha2606
Copy link
Contributor Author

Ashmitha2606 commented Nov 7, 2024 via email

@ANSHIKA-26
Copy link
Owner

i liked the old profile icon better , i told you to make the old icon on all pages , you implemented new icon on all , kindly fix that as well

@Ashmitha2606
Copy link
Contributor Author

Ashmitha2606 commented Nov 7, 2024 via email

@Ashmitha2606
Copy link
Contributor Author

Im closing this request and creating a new one @hiteashgupta1 for this thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants