Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Done Changing the profile icon #1646 #1647

Closed
wants to merge 5 commits into from
Closed

Done Changing the profile icon #1646 #1647

wants to merge 5 commits into from

Conversation

Ashmitha2606
Copy link
Contributor

@Ashmitha2606 Ashmitha2606 commented Nov 3, 2024 •
edited
Loading

Pull Request Checklist

  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .

@vercel Vercel
Copy link

vercel bot commented Nov 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
word-wise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 3:10pm

@Ashmitha2606 Ashmitha2606 changed the title Done Changing the profile icon Done Changing the profile icon #1646 Nov 3, 2024
@Ashmitha2606
Copy link
Contributor Author

@ANSHIKA-26 please check it i have changed profile icon which was mismatched on home page

@ANSHIKA-26
Copy link
Owner

its not working , on clicking it nothing happens , kindly fix

ANSHIKA-26
ANSHIKA-26 requested changes Nov 3, 2024
View reviewed changes
index.html Outdated
<img src="https://i.postimg.cc/NFFmtc9K/xnz-Mst5-V-400x400.jpg" alt="Profile Icon" style="width: 50px; height: 50px; border-radius: 50%; margin-top: -17px;">
</a>
</li>
<a href="#" class="profile-icon" id="profileDropdown" onclick="toggleDropdown()">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the anchor tag , just change the style , if you change the class and onClick event ,it will change the js code too

@Ashmitha2606
Copy link
Contributor Author

Ashmitha2606 commented Nov 3, 2024 via email

@Ashmitha2606
Copy link
Contributor Author

@ANSHIKA-26 i have done the changes please see #1646

@Ashmitha2606
Copy link
Contributor Author

Ashmitha2606 commented Nov 3, 2024 •
edited
Loading

@ANSHIKA-26 hey hi i have completed #1646 (profile change on every page ) and #1644 i have changed the complete ui of blog page with extra transitions and hovering combining for this can you give a level 3

@ANSHIKA-26
Copy link
Owner

can you please follow PR checklist and open a new PR ,? i need before and after changes pictures , a clear description of what you did and issue numbers , also you need to sync fork , thanks

@ANSHIKA-26 ANSHIKA-26 closed this Nov 4, 2024
@Ashmitha2606
Copy link
Contributor Author

Ok sure mill make a new pr and send

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ANSHIKA-26 ANSHIKA-26 ANSHIKA-26 requested changes

Assignees
No one assigned
Labels
gssoc-ext hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashmitha2606 @ANSHIKA-26 @Mallik-vinukonda