-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure Factor Fixes #180
Conversation
…ased on do_1D, do_2D, project_dir, do_slab_sf
…sical location (which doesn't make sense)
@changhokim @HyuntaeJung I think I've fixed all the issues you report EXCEPT being able to do mean-field surface chemistry with the do_2D and do_1D flags. The issue is that for do_2D it assumes the planes have normal z, which is incompatible with MFsurfchem being at the lo-z index. And for do_1D it assumes the pencils are in the x-direction, also incompatible with MFsurfchem convention. |
… work in any direction however if you run a 2D simulation in any context, the normal planes must be in the z direction - there is error checking for cases where there is only 1 plane to make sure the normal is in z
@changhokim @HyuntaeJung I have enabled the ability for mfsurfchem to work in any direction, controlled by project_dir. |
The last thing I need to do is figure out how to run 1D case (both single pencil and uncoupled ensemble) to work with MFsurfchem - I suspect the pencils are in the x-direction and thus project_dir will have to be 0 but I'm not sure yet. |
…of the average of each plane, not the vertical average
-Cleanup logic for when structure factors are permitted and computed based on do_1D, do_2D, project_dir, do_slab_sf.
--This fixes the struct_fact_int>0 and (do_2D=1) case Changho reports.
-Prevent surfCov structure factor from being computed with nx=ny=1
--This fixes the nx=ny=1 and meansurfchem=on case Changho reports.
-Structure factors now report k space index in the plotfile when you query the "physical" location.
--The structure factor data itself is not modified; this only affects the "prob_lo" and "prob_hi" of the plotfile. This is a cosmetic fix only as it allows users using amrVis to easily see kx,ky,kz for a given cell in a SF plotfile.
Ffor uncoupled z-plane case (do_2D=1) the output structure factor is the average over each plane's individual structure factor. There is no SF for vertically averaged data in that case, it makes no sense to do that.