Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jax vectorisation #2636

Merged
merged 10 commits into from
Jan 30, 2025
Merged

jax vectorisation #2636

merged 10 commits into from
Jan 30, 2025

Conversation

FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Jan 29, 2025

Looks like some recent jax update already brought massive improvements to jit time. This reduces compile time by about 4x, (~28s to ~6s on M2 MBA for Bachmann MSB2011)

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.09%. Comparing base (923b8f4) to head (981cefa).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
python/sdist/amici/jax/petab.py 96.29% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2636      +/-   ##
===========================================
+ Coverage    77.02%   77.09%   +0.07%     
===========================================
  Files          332      332              
  Lines        22972    23012      +40     
  Branches      1478     1478              
===========================================
+ Hits         17694    17742      +48     
+ Misses        5267     5259       -8     
  Partials        11       11              
Flag Coverage Δ
cpp 74.20% <83.87%> (+0.07%) ⬆️
cpp_python 33.41% <0.00%> (-0.07%) ⬇️
petab 39.00% <93.54%> (+0.13%) ⬆️
python 72.18% <85.48%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/jax/model.py 87.74% <100.00%> (+0.57%) ⬆️
python/sdist/amici/jax/petab.py 97.42% <96.29%> (-0.72%) ⬇️

... and 3 files with indirect coverage changes

@FFroehlich FFroehlich marked this pull request as ready for review January 29, 2025 21:48
@FFroehlich FFroehlich requested a review from a team as a code owner January 29, 2025 21:48
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

python/sdist/amici/jax/petab.py Outdated Show resolved Hide resolved
@FFroehlich FFroehlich enabled auto-merge January 30, 2025 09:10
@FFroehlich FFroehlich added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit 64de63a Jan 30, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants