Fix profiling of torchax models #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengyifei
force-pushed
the
yifeit/fix-profile
branch
from
4b7e8b0 to
b79b279
Compare
Since torch_xla uses hydra, the CLI for setting profile dir changed
slightly. In order to profile torchax training, we refactor both to
use hydra and the same config name for setting profile dir.
I didn't do that in this PR, but it will be simpler to extend the
torchax trainer to train both llama and mixtral via configs later.
Tested:
python3 torchprime/experimental/torchax_models/run.py global_batch_size=16
tp run torchprime/experimental/torchax_models/run.py \
global_batch_size=128 \
model_type=405B \
seqlen=8192 \
use_custom_offload=True \
use_custom_mesh=True \
model_impl=scan \
tp=4 \
unroll_layers=1
tengyifei
force-pushed
the
yifeit/fix-profile
branch
from
b79b279 to
2ba5fd0
Compare
bhavya01
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since torch_xla uses hydra, the CLI for setting profile dir changed slightly. In order to profile torchax training, we refactor both to use hydra and the same config name for setting profile dir.
I didn't do that in this PR, but it will be simpler to extend the torchax trainer to train both llama and mixtral via configs later.
Tested: