Remove the phoenix-legacy module #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR builds upon #662 and will be rebased. |
This includes code that was added in the modern android app to manage the switch to the legacy app, as well as the migration. Gone as well is the special init TLV sent to the peer to check for legacy channels.
dpad85
force-pushed
the
remove-legacy
branch
from
c5ca53b to
1b3eefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old legacy Android application, and the code in the modern app that was related to the legacy app.
For context, the legacy app, contained in this
phoenix-legacymodule, is first version of Phoenix release in 2020, build around theeclair-coreScala library. It's been deprecated since Phoenix Android v2.0, released in August 2023.Since October 2024, all channels that have ever been created with the legacy app have been closed, and the legacy application is now unusable, and it's now time to remove all the code.
Note that the custom TLV for Phoenix migration that was added in lightning-kmp and eclair can now be removed.
Legacy channels recovery
Legacy channels have all been closed. However some of these channels that were created in specific versions may need to be manually recovered. The easiest way to do that for users is to use the recovery tool present in the legacy app. This tool will not be available after this PR. but users can still download Phoenix v2.4.5 (or versions prior) and perform the recovery there.