Skip to content

Commit

Permalink
(android) Fix error message in liquidity request screen
Browse files Browse the repository at this point in the history
User should be able to retry if the request has failed.
  • Loading branch information
dpad85 committed May 17, 2024
1 parent 3275c84 commit b97513e
Showing 1 changed file with 11 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,15 @@ private fun RequestLiquidityBottomSection(
Spacer(modifier = Modifier.height(16.dp))

when (val state = vm.state.value) {
is RequestLiquidityState.Init -> {
is RequestLiquidityState.Init, is RequestLiquidityState.Complete.Failed -> {
if (state is RequestLiquidityState.Complete.Failed) {
ErrorMessage(
header = stringResource(id = R.string.liquidityads_error_header),
details = spliceFailureDetails(spliceFailure = state.response),
alignment = Alignment.CenterHorizontally
)
Spacer(modifier = Modifier.height(16.dp))
}
BorderButton(
text = if (!mayDoPayments) stringResource(id = R.string.send_connecting_button) else stringResource(id = R.string.liquidityads_estimate_button),
icon = R.drawable.ic_inspect,
Expand Down Expand Up @@ -238,12 +246,6 @@ private fun RequestLiquidityBottomSection(
is RequestLiquidityState.Complete.Success -> {
LeaseSuccessDetails(liquidityDetails = state.response)
}
is RequestLiquidityState.Complete.Failed -> {
ErrorMessage(
header = stringResource(id = R.string.liquidityads_error_header),
details = spliceFailureDetails(spliceFailure = state.response)
)
}
is RequestLiquidityState.Error.NoChannelsAvailable -> {
ErrorMessage(
header = stringResource(id = R.string.liquidityads_error_header),
Expand Down Expand Up @@ -374,6 +376,7 @@ private fun LeaseSuccessDetails(liquidityDetails: ChannelCommand.Commitment.Spli
header = stringResource(id = R.string.liquidityads_success),
details = liquidityDetails.liquidityLease?.amount?.let {
stringResource(id = R.string.liquidityads_success_amount, it.toPrettyString(unit = LocalBitcoinUnit.current, withUnit = true))
}
},
alignment = Alignment.CenterHorizontally,
)
}

0 comments on commit b97513e

Please sign in to comment.