Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Better with Mods' crash as it assumes all beacons are BWM beacons when reading NBT from disk #609

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

Rongmario
Copy link
Contributor

I was tempted to completely nuke saving/loading of the type tag since it is unused in BWM code, but one day it may update and use this particular field. I just assumed same behavior (set default state to AIR)

Copy link

what-the-diff bot commented Dec 22, 2024

PR Summary

  • Inclusion of Better With Mods (BWM) to the Project
    By editing the README.md, dependencies.gradle, and gradle.properties, we've now included the Better With Mods (BWM) as a recognized part of the project. This update provides the project the capacity to make use of BWM's functionality and debug its code when necessary.

  • Added Support and Configuration for BWM
    Changes in UTConfigMods.java and UTMixinLoader.java have also been done to provide support and create a new configuration category for BWM. This includes a toggle switch for the Beacon NBT Loading Fix.

  • Fixing Issues with BWM at the Beacon Tile Entity Level
    A new mixin class, UTTileEntityBeaconMixin.java, was introduced to correct issues with BWM at the beacon tile entity level, specifically on NBT reading concerns.

  • Registering BWM within the Project
    A new mixin configuration file, mixins.mods.bwm.json, has been created to secure the registration of BWM within the project's functionalities. This step secures the integration of BWM to the project's infrastructure.

@ACGaming ACGaming merged commit bb7f93f into ACGaming:main Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants