Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed crash in CCL packet fix by removing extra
release
call. I think in theory having it is necessary, but it deallocates the packet too early if any mod calls any of thesendToXXX
methods on thePacketCustom
object multiple times. I couldn't really come up with a different way to ensure the packet is released before gc'ed in this particular case (without case-by-case modifications). I tested with-Dio.netty.leakDetection.level=paranoid
and didn't seem to find any packet leaks from CCL related networking, so hopefully leaks are still prevented.Also fixed crash with TE monoculture tweak change - forgot a mod check.