contrib: aws-vault proxy listen on 169.254.170.2 #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this endpoint exposes AWS credentials directly to any callers, it is of utmost importance that it not be called by unauthorized 3rd parties. By listening only on 169.254.170.2, we ensure that it's only possible for callers that have access to that IP address to retrieve credentials. This avoids the potential mistake of e.g. hosting this with host networking and allowing it publicly on all available interfaces.
micvbang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Since this endpoint exposes AWS credentials directly to any callers, it is of utmost importance that it not be called by unauthorized 3rd parties. By listening only on 169.254.170.2, instead of all available interfaces, we ensure that it's only possible for callers that have access to that IP address to retrieve credentials. This avoids the potential mistake of e.g. hosting this with Docker's host networking and potentially making it publicly available.