This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Simplifying concurrency model with kotlin coroutines #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed the import queue * much simpler concurrency model based on kotlin co-routines and channels
aldoborrero
reviewed
May 20, 2020
There was a problem hiding this comment.
@brianmcgee have you removed rxjava dependencies from gradle/dependencies and from being imported into ingestion/base?
Not yet, I will clean up the dependencies before marking the PR as no longer a draft. |
…sibility to configure the poll time
Allowing a start block override does not make sense given that some state may be dependent on state from previous blocks and results in foreign key constraints failing on insert.
This reverts commit 4f88df4
Moved kafka ingestor to a separate branch as it requires more work to complete well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the concurrency model within the ingestors, replacing RxJava with Kotlin co-routines.
Type of change
How Has This Been Tested?
Manaul testing for now.
Checklist: