Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use smallest time for block time #193

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

nathanielc
Copy link
Collaborator

Using the instamine option of ganache confuses the CAS worker and it waits forever to see the transaction has been mined. This change uses a block time of 1 second, however in practice this appears to mean a block every 15 seconds. Faster than once a minute but still not very fast.

Using the instamine option of ganache confuses the CAS worker and it
waits forever to see the transaction has been mined. This change uses a
block time of 1 second, however in practice this appears to mean a block
every 15 seconds. Faster than once a minute but still not very fast.
@nathanielc nathanielc requested a review from smrz2001 June 25, 2024 21:06
Copy link
Collaborator

@smrz2001 smrz2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nathanielc nathanielc added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit e8a2bdc Jun 26, 2024
5 checks passed
samika98 pushed a commit that referenced this pull request Jul 12, 2024
Using the instamine option of ganache confuses the CAS worker and it
waits forever to see the transaction has been mined. This change uses a
block time of 1 second, however in practice this appears to mean a block
every 15 seconds. Faster than once a minute but still not very fast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants