Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: aes 84 validate correctness in keramik ceramic anchoring benchmark #184

Merged
merged 13 commits into from
Jun 18, 2024
Merged

feat: aes 84 validate correctness in keramik ceramic anchoring benchmark #184

merged 13 commits into from
Jun 18, 2024

Conversation

samika98
Copy link
Contributor

@samika98 samika98 commented Jun 12, 2024 •
edited
Loading

Features split in this PR :

  • This PR : Add validation to check if all streams are anchored after a configurable run-time. This run-time should be passed in the scenario spec yaml while running the scenario ceramic-anchoring-benchmark
  • This PR: Change cas-benchmark scenario to pass cas-network in the scenario yaml. Use this specified field to decide the cas network to test against. By default use dev. This configuration is optional
  • This PR : Pass in cas-controller from spec for cas-benchmark, cas-controller will be a did:key
  • Verify sync in ceramic-anchoring-benchmark - PR : feat: aes-135-define-a-network-where-we-only-write-to-one-node-and-read #185
  • Convert this into a nightly perf test - NEXT PR

@linear Linear
Copy link

linear bot commented Jun 12, 2024

AES-84 Validate correctness in Keramik Ceramic Anchoring Benchmark Perf test

@samika98 samika98 changed the title Feature/aes 84 validate correctness in keramik ceramic anchoring benchmark feat: aes 84 validate correctness in keramik ceramic anchoring benchmark Jun 13, 2024
@samika98 samika98 self-assigned this Jun 13, 2024
@samika98 samika98 marked this pull request as ready for review June 13, 2024 21:32
@samika98 samika98 mentioned this pull request Jun 17, 2024
Merged
dav1do
dav1do reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@dav1do dav1do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! would like to chat about the dead_code but otherwise just comments for thought 😄

operator/src/simulation/spec.rs Show resolved Hide resolved
runner/src/utils.rs Show resolved Hide resolved
runner/src/simulate.rs Show resolved Hide resolved
runner/src/scenario/ceramic/model_instance.rs Show resolved Hide resolved
dav1do
dav1do reviewed Jun 17, 2024
View reviewed changes
runner/src/simulate.rs Outdated Show resolved Hide resolved
@samika98 samika98 requested a review from dav1do June 17, 2024 23:12
@samika98 samika98 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 2e6c608 Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav1do dav1do dav1do approved these changes

@smrz2001 smrz2001 Awaiting requested review from smrz2001

@nathanielc nathanielc Awaiting requested review from nathanielc

Assignees

@samika98 samika98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samika98 @dav1do