Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update js-ceramic healthcheck timing #183

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

3benbox
Copy link
Contributor

@3benbox 3benbox commented Jun 11, 2024

  • lower initial_delay_seconds so that healthchecks are run faster and pods are marked up earlier
  • lower period_seconds so that there are less healthchecks (already enough load on the system!)
  • increase timeout_seconds as the js-ceramic health check makes its own external calls to "ipfs" which where longer than this setting

@3benbox 3benbox requested review from smrz2001 and dav1do June 11, 2024 02:41
Copy link
Contributor

@dav1do dav1do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems aok and I like reducing the initial_delay_seconds but find it hard to believe the timeouts and period were too low (it makes me sad).

We could consider using different values for startup and liveness like this if we're still seeing odd behavior, or possibly adjust the failureThreshold.

@3benbox 3benbox added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit dbf521e Jun 12, 2024
5 checks passed
@dav1do dav1do deleted the chore/update-js-ceramic-healthcheck-timing branch June 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants