Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report min rps metric even if we failed #142

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

nathanielc
Copy link
Collaborator

No description provided.

@nathanielc nathanielc requested a review from 3benbox February 8, 2024 20:57
Copy link
Contributor

@3benbox 3benbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielc nathanielc enabled auto-merge February 8, 2024 21:02
@nathanielc nathanielc added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit 83f3ad5 Feb 8, 2024
6 checks passed
@nathanielc nathanielc deleted the fix/report-min-rps-failure branch February 8, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants