fix: only specify pubsub topic for inmemory/local #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
approved these changes
Jan 17, 2024
operator/src/network/ceramic.rs
Outdated
| @@ -327,6 +322,17 @@ pub fn stateful_set_spec(ns: &str, bundle: &CeramicBundle<'_>) -> StatefulSetSpe | |||
| }, | |||
| ]; | |||
|
|
|||
| // Only specify the pubsub topic if the network was "inmemory" or "local" | |||
There was a problem hiding this comment.
Can you update this comment for why this is important? Does js-ceramic break if we specify it for some other reason?
There was a problem hiding this comment.
Yes, js-ceramic won't come up if the pubsub topic is specified for any network type but inmemory/local.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.