feat: Remove transaction delays to improve throughput and change meaning of scenario runner users key #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the user value defines how many users to execute for each node. Previously, it was the total users and needed to be evenly divisible by the number of nodes.
dbcfd
approved these changes
Jan 10, 2024
nathanielc
reviewed
Jan 11, 2024
dav1do
added a commit
that referenced
this pull request
Jan 17, 2024
…ing of scenario runner users key (#127) * fix: adjust runner user count to mean users/worker and adjust default value * feat: capture worker error logs * feat: delete long wait times between scenario tx
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
…ing of scenario runner users key (#127) * fix: adjust runner user count to mean users/worker and adjust default value * feat: capture worker error logs * feat: delete long wait times between scenario tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some changes to the runner to improve throughput and make the "users" key easier to understand and more likely to work.
uservalue in the spec is now defined as users/worker (node), rather than being the total users and needing to be divisible by the number of nodes.SIMULATE_THROTTLE_REQUESTSenv var can be used to avoid each worker going bananas. If we want, we can expose the min/max wait as CLI options, as it can be applied to the scenario struct when building it.transaction, scenario, anderror logs on the goose workers as the scenario and transaction were added in feat: add tokio-console support #124.