feat: checkpointer calculate #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbcfd
force-pushed
the
feat/calculate
branch
from
5ca367b to
8e1e871
Compare
dav1do
approved these changes
Feb 26, 2024
| pub struct MaterializationCache { | ||
| model_id: StreamId, | ||
| cli: Box<dyn Ceramic + Send + Sync>, | ||
| cache: HashMap<(String, String), ExistingPoints>, |
There was a problem hiding this comment.
the key would be nicer as a struct with subject/context fields but it's fine
| pub async fn calculate(config: web::Data<Config>) -> Result<impl Responder, Error> { | ||
| if config | ||
| .calculate_active | ||
| .load(std::sync::atomic::Ordering::Relaxed) |
There was a problem hiding this comment.
seems fine but SeqCst might be better if it should really never happen twice (but it's a web api so getting their simultaneously will be really tough)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.