Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACT to include latest Python, Golang bindings patches and changes required for Volumetric extension #399

Closed
wants to merge 3 commits into from

Conversation

vijaiaeroastro
Copy link
Collaborator

This PR brings the latest updates from ACT (develop branch) to lib3mf develop branch

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.08%. Comparing base (2c008ec) to head (073924b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #399   +/-   ##
========================================
  Coverage    66.08%   66.08%           
========================================
  Files          395      395           
  Lines        44625    44625           
========================================
  Hits         29492    29492           
  Misses       15133    15133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gangatp
Copy link
Collaborator

gangatp commented Dec 10, 2024

Hi @vijaiaeroastro , Is there another PR for updating the ACT Bindings and Implementation?

@vijaiaeroastro
Copy link
Collaborator Author

Hi @vijaiaeroastro , Is there another PR for updating the ACT Bindings and Implementation?

@gangatp I will update the title of this PR to include Jan's changes as well. This way, we can incorporate Jan's updates into ACT through a single PR.

@vijaiaeroastro vijaiaeroastro changed the title Update ACT to include latest Python and Golang bindings patches Update ACT to include latest Python, Golang bindings patches and changes required for Volumetric extension Dec 10, 2024
@vijaiaeroastro vijaiaeroastro marked this pull request as draft December 10, 2024 08:40
@3dJan
Copy link
Contributor

3dJan commented Dec 10, 2024

Maybe the PR should also include the changes done by one run of the updated act version. Otherwise theses changes would occur for the next PR that changes something at the API. And #401 would be obsolete.

@vijaiaeroastro
Copy link
Collaborator Author

Maybe the PR should also include the changes done by one run of the updated act version. Otherwise theses changes would occur for the next PR that changes something at the API. And #401 would be obsolete.

@3dJan Once @gangatp approves the PR, I will also regenerate the files along with the commit hash. I missed that even in this PR. Thanks for catching it.

@vijaiaeroastro vijaiaeroastro self-assigned this Dec 10, 2024
@vijaiaeroastro vijaiaeroastro marked this pull request as ready for review December 11, 2024 10:08
@vijaiaeroastro
Copy link
Collaborator Author

@gangatp @3dJan Please check if i copied over everything correctly.

@vijaiaeroastro
Copy link
Collaborator Author

Build seems to fail 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants