-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ACT to include latest Python, Golang bindings patches and changes required for Volumetric extension #399
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #399 +/- ##
========================================
Coverage 66.08% 66.08%
========================================
Files 395 395
Lines 44625 44625
========================================
Hits 29492 29492
Misses 15133 15133 ☔ View full report in Codecov by Sentry. |
Hi @vijaiaeroastro , Is there another PR for updating the ACT Bindings and Implementation? |
@gangatp I will update the title of this PR to include Jan's changes as well. This way, we can incorporate Jan's updates into ACT through a single PR. |
Maybe the PR should also include the changes done by one run of the updated act version. Otherwise theses changes would occur for the next PR that changes something at the API. And #401 would be obsolete. |
@3dJan Once @gangatp approves the PR, I will also regenerate the files along with the commit hash. I missed that even in this PR. Thanks for catching it. |
Build seems to fail 😞 |
This PR brings the latest updates from ACT (develop branch) to lib3mf develop branch