feat: allow pass a ordersVersion for orders queries

1inch · Feb 13, 2025 · f877bc3 · f877bc3
1 parent 4674215
commit f877bc3
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 16 deletions.
diff --git a/src/api/fusion-api.ts b/src/api/fusion-api.ts
@@ -15,7 +15,7 @@ import {
     OrderStatusResponse,
     OrdersByMakerResponse
 } from './orders'
-import {Version} from './version'
+import {OrdersVersion} from './ordersVersion'
 import {AxiosProviderConnector} from '../connector'
 
 export class FusionApi {
@@ -78,9 +78,9 @@ export class FusionApi {
 
     getActiveOrders(
         params: ActiveOrdersRequest = ActiveOrdersRequest.new(),
-        version = Version._2_1
+        ordersVersion = OrdersVersion._2_1
     ): Promise<ActiveOrdersResponse> {
-        return this.ordersApi.getActiveOrders(params, version)
+        return this.ordersApi.getActiveOrders(params, ordersVersion)
     }
 
     getOrderStatus(params: OrderStatusRequest): Promise<OrderStatusResponse> {
@@ -89,9 +89,9 @@ export class FusionApi {
 
     getOrdersByMaker(
         params: OrdersByMakerRequest,
-        version = Version._2_1
+        ordersVersion = OrdersVersion._2_1
     ): Promise<OrdersByMakerResponse> {
-        return this.ordersApi.getOrdersByMaker(params, version)
+        return this.ordersApi.getOrdersByMaker(params, ordersVersion)
     }
 
     submitOrder(params: RelayerRequest): Promise<void> {

diff --git a/src/api/index.ts b/src/api/index.ts
@@ -5,3 +5,4 @@ export * from './orders/index'
 export * from './fusion-api'
 export * from './pagination'
 export * from './types'
+export * from './ordersVersion'
diff --git a/src/api/orders/order-api.spec.ts b/src/api/orders/order-api.spec.ts
@@ -255,7 +255,7 @@ describe(__filename, () => {
 
             expect(response).toEqual(expected)
             expect(httpProvider.get).toHaveBeenLastCalledWith(
-                `${url}/orders/v2.0/1/order/status/${orderHash}?version=2.1`
+                `${url}/orders/v2.0/1/order/status/${orderHash}`
             )
         })
 

diff --git a/src/api/orders/orders.api.ts b/src/api/orders/orders.api.ts
@@ -11,7 +11,7 @@ import {
 } from './types'
 import {AxiosProviderConnector, HttpProviderConnector} from '../../connector'
 import {concatQueryParams} from '../params'
-import {Version, VERSION} from '../version'
+import {OrdersVersion} from '../ordersVersion'
 
 export class OrdersApi {
     private static Version = 'v2.0'
@@ -32,15 +32,15 @@ export class OrdersApi {
 
     async getActiveOrders(
         params: ActiveOrdersRequest,
-        version: Version
+        ordersVersion: OrdersVersion
     ): Promise<ActiveOrdersResponse> {
         const err = params.validate()
 
         if (err) {
             throw new Error(err)
         }
 
-        const queryParams = concatQueryParams(params.build(), version)
+        const queryParams = concatQueryParams(params.build(), ordersVersion)
         const url = `${this.config.url}/${OrdersApi.Version}/${this.config.network}/order/active/${queryParams}`
 
         return this.httpClient.get<ActiveOrdersResponse>(url)
@@ -55,22 +55,22 @@ export class OrdersApi {
             throw new Error(err)
         }
 
-        const url = `${this.config.url}/${OrdersApi.Version}/${this.config.network}/order/status/${params.orderHash}?version=${VERSION}`
+        const url = `${this.config.url}/${OrdersApi.Version}/${this.config.network}/order/status/${params.orderHash}`
 
         return this.httpClient.get<OrderStatusResponse>(url)
     }
 
     async getOrdersByMaker(
         params: OrdersByMakerRequest,
-        version: Version
+        ordersVersion: OrdersVersion
     ): Promise<OrdersByMakerResponse> {
         const err = params.validate()
 
         if (err) {
             throw new Error(err)
         }
 
-        const qp = concatQueryParams(params.buildQueryParams(), version)
+        const qp = concatQueryParams(params.buildQueryParams(), ordersVersion)
         const url = `${this.config.url}/${OrdersApi.Version}/${this.config.network}/order/maker/${params.address}/${qp}`
 
         return this.httpClient.get(url)

diff --git a/src/api/version.ts → src/api/ordersVersion.ts b/src/api/version.ts → src/api/ordersVersion.ts
@@ -1,5 +1,4 @@
-export const VERSION = '2.1'
-export enum Version {
+export enum OrdersVersion {
     all = 'all',
     _2_1 = '2.1',
     _2_0 = '2.0'

diff --git a/src/api/params.ts b/src/api/params.ts
@@ -1,11 +1,11 @@
-import {Version} from './version'
+import {OrdersVersion} from './ordersVersion'
 
 /**
  * Concat all params to query encoded string. if `addVersion` is true, then `version` param is added to this string
  */
 export function concatQueryParams<
     T extends Record<string | number, string | string[] | number | boolean>
->(params: T, version: false | Version = false): string {
+>(params: T, version: false | OrdersVersion = false): string {
     if (!params) {
         return version ? `?version=${version}` : ''
     }