Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid internal modifiers to simplify logic #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

k06a
Copy link
Member

@k06a k06a commented Jun 17, 2024

Static Code Analysis (readability, compactness):

I think modifiers on internal methods are a bit harder to follow, so tried to avoid it.

Dynamic Code Analysis (external APIs, interaction flows):

Similar behavior

Efficiency (gas costs, computational complexity, memory requirements):

A bit cheaper (10-20 gas) due to inlining probably

Opinion, trade-offs and other thoughts:

I don't have strong opinion here, but code seems easier to follow

@k06a k06a requested review from ZumZoom and byshape June 17, 2024 10:51
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.49%. Comparing base (b3acc0f) to head (6f1e073).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   70.49%   70.49%           
=======================================
  Files          16       16           
  Lines         122      122           
  Branches       19       19           
=======================================
  Hits           86       86           
  Misses         35       35           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants