Avoid internal modifiers to simplify logic #75
+66
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static Code Analysis (readability, compactness):
I think modifiers on internal methods are a bit harder to follow, so tried to avoid it.
Dynamic Code Analysis (external APIs, interaction flows):
Similar behavior
Efficiency (gas costs, computational complexity, memory requirements):
A bit cheaper (10-20 gas) due to inlining probably
Opinion, trade-offs and other thoughts:
I don't have strong opinion here, but code seems easier to follow