You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've got no idea whether there is any precedent for this, but it seems like orgmode global options could be set in the same defaults table of the fzf setup which could be accessed using require('fzf-lua').config.globals.defaults.orgmode (assuming the table is called orgmode).
This might help with the "use fzf-lua’s own defaults system" mentioned in the development file, but I have no idea if this is the usual way to do this.
Thanks a lot for the plugin!
The text was updated successfully, but these errors were encountered:
@sandersantema , thanks for checking out the plugin and opening this issue!
I think what you're describing is along the lines of what I had in mind in DEVELOPMENT.org. But I was specifically talking about the actions configuration. I haven't tried the defaults thing yet, but are you sure that works? It doesn't seem documented anywhere.
I've got no idea whether there is any precedent for this
I think that's why I'm not super clear on what exactly. I don't have any idea about precedent either. It seems like fzf-lua only specifies two actions can be inherited by other providers, files and buffers:
It has its own notion of defaults internally, and merges those with setup_opts and call_opts (with later opts taking precedence), but I haven't seen anything that suggests the defaults system is meant to be exposed for third-party providers. In fact, it's not clear to what I should be doing as third-party provider, but perhaps I just haven't looked hard enough.
Separately, all of the options in my plugin inherit from the orgmode configuration, but that's because everything in my plugin is implemented as a specialization of options that go through a single orgmode provider. I'm not sure fzf-lua does that.
The right way to do this would be to file some issues and ask ibhagwan for advice. But I wanted to kick the tires on the plugin as written before doing that, and prioritize other features like nicer reloading and a live_grep-like interface for interactive orgmode searches.
Assuming it doesn't conflict with
fzf-org
's own options, I think it might be a nice idea to inherit the globalfzf-lua
options, i.e. those set as:Currently this can be done as follows:
I've got no idea whether there is any precedent for this, but it seems like
orgmode
global options could be set in the samedefaults
table of thefzf
setup which could be accessed usingrequire('fzf-lua').config.globals.defaults.orgmode
(assuming the table is calledorgmode
).This might help with the "use fzf-lua’s own defaults system" mentioned in the development file, but I have no idea if this is the usual way to do this.
Thanks a lot for the plugin!
The text was updated successfully, but these errors were encountered: