Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce websocket support #619

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Introduce websocket support #619

merged 10 commits into from
Oct 2, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Sep 26, 2024

Usage related changes

Development related changes

  • Currently targeting branch json-rpc-v0.8.0, but could be changed already to main at no breaking cost, in which case a rebase would be needed.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC marked this pull request as ready for review October 1, 2024 11:53
@marioiordanov
Copy link
Collaborator

No need for now to merge into main

@FabijanC FabijanC merged commit ac2aabe into json-rpc-v0.8.0 Oct 2, 2024
@FabijanC FabijanC deleted the websocket branch October 2, 2024 07:39
@FabijanC FabijanC mentioned this pull request Oct 2, 2024
7 tasks
FabijanC added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants