frontend: translate mem::intrinsics::heap_base
#397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
changed the title
mem::intrinsics::heap_basemem::intrinsics::heap_base
greenhat
commented
Feb 11, 2025
| .component | ||
| .borrow_mut() | ||
| .symbol_manager_mut() | ||
| .insert_new(module_ref, crate::ProgramPoint::Invalid); |
There was a problem hiding this comment.
@bitwalker I'm wondering if the symbol registration is better to be done in the op builder (module in this case)? When I first encountered this (function creation in the module) I was quite surprised that new function is not automatically registered in module symbol table.
There was a problem hiding this comment.
Good catch, I must've never added the logic to automatically register new symbol ops when inserted into a symbol table op. That should probably be done as some sort of hook that fires anytime an op is inserted into a region (or removed from one), but for now we'll have to just implement the logic in the op-specific builders manually.
bitwalker
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #396
This PR add translation for
mem::intrinsics::heap_baseby creating a module(mem::intrinsics) with an "empty" function (heap_base) since the real function implementation is linked at the codegen.