[11/x] UseFileName::as_strfor source file name to avoid enclosing virtual filenames in brackets

[greenhat]

This PR is stacked on the #218 and should be merged after it

Use FileName::as_str for source name in Wasm translation to avoid <name> (enclosed in brackets) which is produced by FileName::to_string since the brackets are illegal in MASM module ids.

[bitwalker]

Having thought about this some more, I think actually we should tackle this issue a bit differently. See my comment here. I'm going to leave this marked approved for now, so we can merge it as a temporary workaround, but the fundamental issue here requires a more appropriate fix I think. We can address it properly in another PR, or in this one, whichever you think is more appropriate.

[greenhat]

Having thought about this some more, I think actually we should tackle this issue a bit differently. See my comment here. I'm going to leave this marked approved for now, so we can merge it as a temporary workaround, but the fundamental issue here requires a more appropriate fix I think. We can address it properly in another PR, or in this one, whichever you think is more appropriate.

I'm not sure if I follow. I'm using "unbracketed" name here to avoid ConvertHirToMasm failing at

compiler/codegen/masm/src/convert.rs

Line 117 in 8b8117f

panic!("invalid module name '{}': {}", module.name.as_str(), err)

I suppose we can leave brackets but treat every module name there as raw ids. Is that the idea?

[bitwalker]

Right, my bad, I got this one mixed in with other issues related to module/procedure paths